Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedDataMiddleware adds utf-8 charset #1712

Merged
merged 1 commit into from Feb 6, 2020
Merged

SharedDataMiddleware adds utf-8 charset #1712

merged 1 commit into from Feb 6, 2020

Conversation

davidism
Copy link
Member

@davidism davidism commented Feb 6, 2020

closes #1689

Uses get_content_type to add the utf-8 charset if the filename looks like a text mimetype. This matches the behavior of Werkzeug's Response and Flask's send_file.

@davidism davidism added this to the 1.0.0 milestone Feb 6, 2020
@davidism davidism merged commit 1daf2c7 into master Feb 6, 2020
@davidism davidism deleted the shared-data-charset branch February 6, 2020 05:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

set charset in shareddatamiddleware
1 participant
@davidism