Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range request always returns 206 status #1711

Merged
merged 1 commit into from Feb 6, 2020
Merged

range request always returns 206 status #1711

merged 1 commit into from Feb 6, 2020

Conversation

davidism
Copy link
Member

@davidism davidism commented Feb 6, 2020

closes #410
closes #1704

I had trouble finding anyone who could reproduce this on modern Safari, Firefox, or Chrome, desktop or mobile. But #1704 reports that this fixed their issue, and it's more compliant with the RFC. The range headers themselves are parsed and produced correctly, so this is the only other explanation for #410 as far as I could tell.

@davidism davidism added this to the 1.0.0 milestone Feb 6, 2020
@davidism davidism mentioned this pull request Feb 6, 2020
@davidism davidism merged commit 0474354 into master Feb 6, 2020
@davidism davidism deleted the video-range branch February 6, 2020 04:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_conditional(..., accept_ranges=True) respond range request with 200 OK Can't serve html video
1 participant