Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Werkzeug's logger + default level/handler #1708

Merged
merged 1 commit into from Feb 4, 2020
Merged

Document Werkzeug's logger + default level/handler #1708

merged 1 commit into from Feb 4, 2020

Conversation

bsolomon1124
Copy link
Contributor

@bsolomon1124 bsolomon1124 commented Jan 27, 2020

While logging is handle in _internal.py, it is common practice for the logger object itself, plus its default level and handler, to be public-facing. This commit documents those three components.

@davidism
Copy link
Member

The werkzeug logger is only used for dev server messages. Under what circumstances do you need access to this? Remember, the dev server should only be used for local development, where it pretty much only makes sense to log to the terminal you're running the dev server in.

@bsolomon1124
Copy link
Contributor Author

@davidism While I understand that the server is expressly labeled as not-production-ready, I don't think that precludes typical use cases like, for instance, wanting to add a FileHandler or change the logger's format. But don't let me hold you back from closing this PR if you feel otherwise.

@davidism davidism added the docs label Feb 4, 2020
@davidism davidism merged commit 07e3c97 into pallets:master Feb 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants