don't detect executable file for reloader #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts #1242 In order to support NixOS wrappers, the reloader would call an executable script directly. This caused issues with Windows, Docker, and other common development environments, resulting in an "Exec format error". Revert that change until a better workaround can be found.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support NixOS wrappers, the reloader would call an executable script directly. This caused issues with Windows, Docker, and other common development environments, resulting in an "Exec format error". Revert that change until a better workaround can be found.
Reverts #1242
Fixes #1482
Fixes #1504
Fixes #1580
Fixes pallets/flask#3133
Fixes pallets/flask#3189
cc @samdroid-apps