New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SyntaxError on python 2.7.5 #1545
Conversation
Would you retarget to 0.15.x? Also, this seems to break the tests. tests/test_routing.py:29: in test_basic_routing
r.Rule("/bar/", endpoint="bar"),
.tox/py/lib/python3.7/site-packages/werkzeug/routing.py:1347: in __init__
self.add(rulefactory)
.tox/py/lib/python3.7/site-packages/werkzeug/routing.py:1388: in add
rule.bind(self)
.tox/py/lib/python3.7/site-packages/werkzeug/routing.py:730: in bind
self.compile()
.tox/py/lib/python3.7/site-packages/werkzeug/routing.py:794: in compile
self._build = self._compile_builder(False).__get__(self, None)
.tox/py/lib/python3.7/site-packages/werkzeug/routing.py:952: in _compile_builder
return self._get_func_code(code, func_ast.name)
.tox/py/lib/python3.7/site-packages/werkzeug/routing.py:859: in _get_func_code
return locs[name]
E KeyError: "<builder:'/'>" |
lol oops, transposed |
I was trying to spot the difference 😆 |
You'll need to |
fixed my rebase too -- oops, I'm sick and not thinking super straight |
Thanks for the quick fix! |
No problem! Ya learn some archaic fact every day I guess 😆 |
Resolves #1544
Here's the test plan I used, since we can't install 2.7.5 in CI this'll have to do: