simplify CodeType rewriting #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I can see from https://cloud.google.com/appengine/docs/standard/runtimes and other docs, the modern GAE runtime is unmodified, unlike the legacy Python 2 runtime. Based on that, I'm going to merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CodeType.replaceto greatly simplify replacingco_nameon Python 3.8+. Only Python 3.7 needs to use all positional arguments. No longer need to replaceco_filename, it's already replaced bycompile. Removetry/exceptblock to avoid hiding errors with this code in the future; need to test that modern GAE works with this.fixes #1334