Use object.__hash__
for Node.__hash__
#1522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in commit 6029341 that
changed the
__hash__
implementation of Node from the default pointerhash, to a hash based on the node fields.
Since these fields contain list objects, they are not hashable, making
every call to
Node.__hash__
fail.This breaks some third-party usage such as in
django-compressor
(See: django-compressor/django-compressor#1060)
This change reverts the hash method back to using
object.__hash__
asthe hash implementation.
Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.