Added unique filter #469
Closed
Added unique filter #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2015
Closed
ThiefMaster
reviewed
Jan 29, 2017
| @@ -51,21 +51,24 @@ def environmentfilter(f): | |||
| return f | |||
|
|
|||
|
|
|||
| def make_attrgetter(environment, attribute): | |||
| def make_attrgetter(environment, attribute, lowercase=False): | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
davidism
requested changes
Apr 13, 2017
| @@ -51,21 +51,24 @@ def environmentfilter(f): | |||
| return f | |||
|
|
|||
|
|
|||
| def make_attrgetter(environment, attribute): | |||
| def make_attrgetter(environment, attribute, lowercase=False): | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| key = getter(item) | ||
| if key not in seen: | ||
| seen.add(key) | ||
| rv.append(item) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Needs a changelog entry. |
|
@snoack Are you yet interested in fixing this PR? |
Merged
|
Continued in #735 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 years ago I suggested to add a
uniquefilter, along with some other new filters as part of #66. That pull request has been closed, after some parts of it got implemented independently. However, I just saw a similar request (#443) for excluding duplicates using filters. So I rebased my old patch, added tests and did some logical improvements, that it hopefully get merged now.