Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow namespaces to be used in asynchronously rendered templates. #1181

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Allow namespaces to be used in asynchronously rendered templates. #1181

merged 1 commit into from
Mar 30, 2020

Conversation

bartfeenstra
Copy link
Contributor

This fixes #1180, by allowing Namespace instances to undergo the type checks necessary for async compatibility.

ThiefMaster
ThiefMaster reviewed Mar 28, 2020
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
ThiefMaster
ThiefMaster approved these changes Mar 29, 2020
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
@davidism davidism changed the base branch from master to 2.11.x March 30, 2020 18:28
@davidism davidism added this to the 2.11.2 milestone Mar 30, 2020
@davidism davidism merged commit 786867a into pallets:2.11.x Mar 30, 2020
@bartfeenstra bartfeenstra deleted the async-namespace branch March 31, 2020 20:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.2
Development

Successfully merging this pull request may close these issues.

Using namespaces asynchronously raises fatal AttributeError
3 participants
@bartfeenstra @ThiefMaster @davidism