Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute access in async code. #1143

Merged
merged 3 commits into from Jan 30, 2020
Merged

Fix attribute access in async code. #1143

merged 3 commits into from Jan 30, 2020

Conversation

mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Jan 30, 2020 •
edited by davidism

Fixes #1141

@davidism
Copy link
Member

davidism commented Jan 30, 2020 •
edited

Some missing parentheses from #1101. On chained attribute and slice access, the compiler without the parentheses was making the slice apply to the result of auto_await(), rather than (await auto_await()).

@davidism davidism changed the base branch from master to 2.11.x January 30, 2020 17:40
@davidism davidism added this to the 2.11.1 milestone Jan 30, 2020
@davidism davidism merged commit 3d5bfc6 into 2.11.x Jan 30, 2020
@davidism davidism deleted the bugfix/attribute-access branch January 30, 2020 17:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitsuhiko @davidism