New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle OverflowError on parsing timestamps as BadTimeSignature #299

Merged

davidism merged 1 commit into pallets:2.1.x from dirkmueller:main

Mar 24, 2022

Contributor

dirkmueller commented Mar 24, 2022 •

edited

on 32bit platforms the test TestTimestampSigner::test_malformed_future_timestamp
causes an OverflowError. Catch this and raise it as BadTimeSignature

Signed-off-by: Dirk Müller dirk@dmllr.de

fixes catch overflow error on 32bit platforms #300

Checklist:

Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
Add or update relevant docs, in the docs folder and in code.
Add an entry in CHANGES.rst summarizing the change and linking to the issue.
Add .. versionchanged:: entries in any relevant code docs.
Run pre-commit hooks and fix any issues.
Run pytest and tox, no tests failed.

davidism added this to the 2.1.2 milestone


          handle OverflowError in timed unsign on 32-bit systems

3edfbbb

davidism force-pushed the main branch from 551c0b0 to 3edfbbb Compare

March 24, 2022 14:58

davidism changed the base branch from main to 2.1.x

March 24, 2022 14:58

davidism merged commit 64cd581 into pallets:2.1.x

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.