Skip to content

show warning for old logger config #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

show warning for old logger config #3284

merged 1 commit into from
Jul 2, 2019
+41 −3

Conversation

davidism
Copy link
Member

@davidism davidism commented Jul 2, 2019 •
edited
Loading

Adds a warning for #3282 when config for the "flask.app" or "flask" loggers is found and the logger for app.name isn't configured.

UserWarning: 'app.logger' is named 'example' for this application, but configuration was found for 'flask.app', which no longer has an effect. The logging configuration should be moved to 'example'.

closes #3283

@davidism
show warning for old logger config

Verified

This commit was signed with the committer’s verified signature.
davidism David Lord
GPG key ID: 7A1C87E3F5BC42A8
Verified
Learn about vigilant mode
b08e35e
@davidism davidism added this to the 1.1.0 milestone Jul 2, 2019
@davidism davidism merged commit 6d0e79b into master Jul 2, 2019
@davidism davidism deleted the logger-warning branch July 2, 2019 18:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThiefMaster ThiefMaster

Assignees
No one assigned
Labels
logging
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Warn about logging name change
2 participants
@davidism @ThiefMaster