Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/test_types.py::test_file_surrogates test is missing the skipif not _non_utf8_filenames_supported marker #2634

Open
RuRo opened this issue Nov 23, 2023 · 0 comments

Comments

@RuRo
Copy link

RuRo commented Nov 23, 2023

The title says it all. There are a bunch of tests in tests/test_types.py that do some checks with non-utf8 filenames. Some filesystems don't support non-utf8 filenames, so the main test_path_surrogates test is conditionally disabled with

@pytest.mark.skipif(
    not _non_utf8_filenames_supported(),
    reason="The current OS or FS doesn't support non-UTF-8 filenames.",
)

However, the next two tests (test_file_surrogates and test_file_error_surrogates) are missing these marks.

The fix should be pretty simple - add the above-mentioned decorator to these tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant