New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pathlib to resolve symlinks #2094

Merged

davidism merged 1 commit into 8.0.x from path-resolve-symlink

Oct 10, 2021

Member

davidism commented Oct 10, 2021

pathlib.Path(value).resolve() will resolve paths with symlinks consistently, including on Windows Python < 3.8.

fixes 8.0.2 doesn't validate paths correctly #2088

Checklist:

Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
Add or update relevant docs, in the docs folder and in code.
Add an entry in CHANGES.rst summarizing the change and linking to the issue.
Add .. versionchanged:: entries in any relevant code docs.
Run pre-commit hooks and fix any issues.
Run pytest and tox, no tests failed.


          use pathlib to resolve symlinks

c8ca29b

davidism added this to the 8.0.3 milestone

davidism merged commit 3737511 into 8.0.x

davidism deleted the path-resolve-symlink branch

October 10, 2021 17:19

sanderr mentioned this pull request

skip click-8.0.2 but allow patched versions cloudsmith-io/cloudsmith-cli#60

Merged

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.