Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show help text with invalid default #1916

Merged
merged 1 commit into from May 19, 2021
Merged

show help text with invalid default #1916

merged 1 commit into from May 19, 2021

Conversation

davidism
Copy link
Member

If ctx.resilient_parsing is enabled, type casting can fail when getting the default, and the raw invalid value will be returned instead. Showing help text temporarily enables resilient parsing mode when fetching the default. I wasn't sure what the effect would be of enabling that for the entire help formatting, so it's just local to the default right now.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.0.1 milestone May 19, 2021
@davidism davidism merged commit fcf8205 into 8.0.x May 19, 2021
@davidism davidism deleted the default-resilient branch May 19, 2021 18:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant