Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return resolved name, not original name #1915

Merged
merged 1 commit into from May 19, 2021
Merged

return resolved name, not original name #1915

merged 1 commit into from May 19, 2021

Conversation

davidism
Copy link
Member

Reverts #1422, but updates the documentation to get the desired behavior instead. Always returning the command's original name ignored that the command could be registered with a different name like group.add_command(cmd, name).

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.0.1 milestone May 19, 2021
@davidism davidism merged commit 1b49159 into 8.0.x May 19, 2021
@davidism davidism deleted the command-name branch May 19, 2021 17:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant