repr is erasing ANSI escapes codes #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
allow_colors_in_metavar
branch
from
fb986d6
to
e3e1691
Compare
|
Thanks for catching this, I fixed the other repr you pointed out. What's happening is that repr is escaping the non-printable control characters so that they're displayed as their string repr instead of controlling the terminal. repr was used as a shortcut for putting single quotes around things, so this might be something to change in other places as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow colors in argument hint.
What about str() vs f"{}" ?
Should I update : return " / ".join(repr(x) for x in hint_list) too ?