Intoduce timeout as a feature #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
palfrey
requested changes
Jul 1, 2022
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
|
Oh darn, I should have probably run the tests with no default features, sorry :) |
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Merged
palfrey
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
timeouta feature that is by default enabled, this preserves the API for backward compatibility.I also switched the Mutex of the MAX_WAIT to an RwLock, it's not on the critical path but it seemed sensible since it's mostly ever read and rarely written - it also removed two imports :)
I'll follow up with per test timeouts & eventual sequential start in further PRs