Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rustversion declaration to a dev-dependency #69

Merged
merged 1 commit into from Jun 27, 2022

Conversation

complexspaces
Copy link
Contributor

This PR moves the use of rustversion in the Cargo.toml to the dev-dependency section instead of the regular dependencies.

This crate is only used in tests, so its the correct location for it. Otherwise, downstream consumers will have it put in their Cargo.lock files for no reason other than to build it.

@palfrey palfrey merged commit 714def9 into palfrey:main Jun 27, 2022
@palfrey
Copy link
Owner

palfrey commented Jun 27, 2022

Thanks. IIRC I suspect I thought I was going to use it for a build.rs script or something and forgot to move it to dev deps even after I realised that wasn't the case.

@palfrey
Copy link
Owner

palfrey commented Aug 10, 2022

Released as part of 0.9.0

@complexspaces complexspaces deleted the correctly-use-dev-dep branch January 30, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants