Possiblity to disable dependency on futures?
#73
Comments
334: Simplify snapshot tests r=justahero a=Urhengulas This PR simplifies the probe-run snapshot tests by using the `rstest` macro. ~~Additionally we update the dependencies used in the tests.~~ # How to test the tests These tests are ignored by default, since they require the hardware (`nrf52840dk`) to be present. You can run them locally by connecting your computer to the nrf52 and executing `cargo test -- --ignored`. # Reviewer notes Please don't get intimidated by the number of files and lines changed. Most of the files are just renamed to work with `rstest` and the new name of the test file. The many deleted lines are because the stack overflow test got simplified in the past, but the output wasn't adapted yet. You should mainly focus on `tests/snapshot.rs`. # Remarks Note that the `panic_verbose` test will fail in most cases. It's because this test output contains timing related numbers, which will slightly change from run to run. This also happened before this PR, therefore isn't a regression, but should be fixed in the future. ~~Note that updating `serial_test` pulls in many `futures-*` libraries, which seems unnecessary since we are not using any async functions. I've asked if that can be avoided: palfrey/serial_test#73 --- Edit(1): Drop dependency update from this PR, in order to unblock it. Edit(2): Add reviewer notes. Edit(3): Add section on how to tests the tests and structure the PR description. Co-authored-by: Urhengulas <johann.hemmann@code.berlin> Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
|
Previously, I would have said "no", because I seemed to recall trying to do this when implementing the async support to begin with and it didn't work. But I've just poked at things again and it looks doable. Should have a PR for this at some point... |
Thank you for taking this on! 🙇🏾♂️ |
|
#74 is the start of things, and it probably just needs some minor more fixes to resolve out some cases of some particular combinations of features not working well together TBH. |
|
The |
I will test it! Thank you! |
|
I just tested it and now I guess you could publish that as a patch release, since the |
|
I'm planning a 0.9.0 release soon with some other stuff and this will get folded into that. |
Nice. Thank you very much! |
|
Released as part of 0.9.0 |
345: Update dev-dependency `serial_test` r=Urhengulas a=Urhengulas Blocked on palfrey/serial_test#73 getting released in `serial_test 0.9`. Co-authored-by: Urhengulas <johann.hemmann@code.berlin>
345: Update dev-dependency `serial_test` r=Urhengulas a=Urhengulas Blocked on palfrey/serial_test#73 getting released in `serial_test 0.9`. Co-authored-by: Urhengulas <johann.hemmann@code.berlin>
Hello,
Thank you for your library! We are using it in https://github.com/knurling-rs/probe-run and it comes in very handy 😁
I am just upgrading from
0.5.1to0.8.0and am seeing that this adds the additional dependencyfutures, which in turn pulls in "futures-channel", "futures-core", "futures-executor", "futures-io", "futures-sink", "futures-task" and "futures-util". Which is a lot 😵💫Since we are not using any async functions, is there the possibility to make this dependency optional by hiding it behind a (default) feature?
👋🏾
The text was updated successfully, but these errors were encountered: