Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

#4326 - TypeError: Cannot read property 'param' of undefined #4895

Merged
merged 7 commits into from
Dec 8, 2019

Conversation

ChaiWithJai
Copy link
Contributor

@ChaiWithJai ChaiWithJai commented Nov 28, 2019

PR checklist

Overview of change:

There was an issue with setting the tag variable of the jsDoc rule to an empty array. The empty array wasn't a case that the exclude function was capturing. I added a case of what to do if the contentTag is undefined.

Is there anything you'd like reviewers to focus on?

N/A

CHANGELOG.md entry:

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @JBhagat841! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JBhagat841! 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'param' of undefined
3 participants