Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Removed annoying formatting rules from recommended ruleset #4871

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Removed annoying formatting rules from recommended ruleset #4871

merged 4 commits into from
Oct 7, 2019

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 5, 2019

PR checklist

Overview of change:

Removes a bunch of rules from recommended.ts around formatting and whitespace. Also adds allow-leading-underscore to variable-name.

CHANGELOG.md entry:

[rule-change] Removed formatting and whitespace rules from recommended ruleset

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/configs/recommended.ts Show resolved Hide resolved
src/configs/recommended.ts Outdated Show resolved Hide resolved
src/configs/recommended.ts Outdated Show resolved Hide resolved
@adidahiya adidahiya merged commit a108465 into palantir:master Oct 7, 2019
@JoshuaKGoldberg JoshuaKGoldberg deleted the trim-recommended branch October 7, 2019 17:11
@dbartholomae
Copy link

When will this be released? :)

mgechev pushed a commit to angular/angular-cli that referenced this pull request Mar 17, 2020
In tslint version 6, several recommanded rules have been removed in the following PRs:
palantir/tslint#4871 palantir/tslint#4312

With this change, we bring back these rules in the CLI.
mgechev pushed a commit to angular/angular-cli that referenced this pull request Mar 17, 2020
In tslint version 6, several recommanded rules have been removed in the following PRs:
palantir/tslint#4871 palantir/tslint#4312

With this migration we update the tslint depedency to 6+ and add back these rules in the user workspace `tslint.json` also we remove some deprecated rules.

Until version 10, this is an opt-in migration and users will need to run this manually with the below command:
```
ng update @angular/cli --migrate-only tslint-version-6
```

Closes: #17117
Reference: TOOL-1348
@ThibaudAV
Copy link

😢 @JoshuaKGoldberg why these changes? it removes a lot of very appreciable rules in the so-called "recommended" rule set

@Flowkap
Copy link

Flowkap commented Aug 4, 2020

Great .. i was wondering why code suddenly did not have enforced rules. Trailingsemicolon and commans are for better git changelogs. We relied on the recommended to better document what we wanted to tweak... this was probably a wrong decision ... No wi need to clean up a lot of mess cause devs of course upgraded tslint package and got less strict new defaults.

@dbartholomae
Copy link

For pure styling I would recommend prettier. This will also autofix your code :)

@Flowkap
Copy link

Flowkap commented Aug 4, 2020

For good reason were not. Those checks are not for styling but good reason as clean git history. I would approve some of the removals which are highly opinionated. But commans and curly braces as well as semicolons have more meaning and often clutter diffs.

@adidahiya
Copy link
Contributor

This change to the recommended rule set had been planned for a very long time. TSLint is deprecated and we won't be making any more significant changes to its API.

@palantir palantir locked as resolved and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants