Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix: add option to enforce alphabetical ordering regardless of blank lines #4808

Merged
merged 2 commits into from Jul 25, 2019

Conversation

vedadeepta
Copy link
Contributor

@vedadeepta vedadeepta commented Jul 24, 2019

PR checklist

Overview of change:

Added a option allow-blank-lines to rule object-literal-sort-keys which enforces alphabetical ordering regardless of blank lines between key/value pairs.

Is there anything you'd like reviewers to focus on?

Not sure if the option name allow-blank-lines is correct.

CHANGELOG.md entry:

[new-rule-option] ignore-blank-lines option for object-literal-sort-keys rule

@vedadeepta vedadeepta changed the title fix: add option to enfore alphabetical ordering regarding of blank lines fix: add option to enfore alphabetical ordering regardless of blank lines Jul 24, 2019
@vedadeepta vedadeepta changed the title fix: add option to enfore alphabetical ordering regardless of blank lines fix: add option to enforce alphabetical ordering regardless of blank lines Jul 24, 2019
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but let's call the option "ignore-blank-lines"

@adidahiya adidahiya merged commit 9924e7a into palantir:master Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for object-literal-sort-keys to not ignore blank lines
2 participants