This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[no-inferred-empty-object-type] Skip test in TS > 3.4.x #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the generic parameters are inferred as `unknown` in newer TS versions (> 3.4.x), this rule no longer applies in those versions, and those places that would have previously thrown an error, as seen in the tests, no longer should throw as they are no longer inferred as `{}`.
adidahiya
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the generic parameters are inferred as
unknownin newer TS versions (> 3.4.x), this rule no longer applies in those versions, and those places that would have previously thrown an error, as seen in the tests, no longer should throw as they are no longer inferred as{}.PR checklist
Overview of change:
TS above 3.4.x infers the types to
unknowninstead of{}, so the tests no longer apply.CHANGELOG.md entry:
[no-log]