Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[enhancement] Update nyc from v10.2.0 to v13.3.0 #4633

Merged
merged 1 commit into from Apr 3, 2019

Conversation

bjornstar
Copy link
Contributor

PR checklist

  • New feature, bugfix, or enhancement

Overview of change:

Update nyc from v10.2.0 to v13.3.0

Is there anything you'd like reviewers to focus on?

The number of known vulnerabilities for tslint's dependencies drops from 29 to 3.

✔  17:26 ~/tslint [ update-nyc L | ✔  ] $ npm install nyc
+ nyc@10.3.2
updated 1 package and audited 812 packages in 3.634s
found 29 vulnerabilities (17 low, 9 moderate, 2 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
✔  17:27 ~/tslint [ update-nyc L | ✚ 1 ] $ npm i nyc@latest
+ nyc@13.3.0
added 61 packages from 65 contributors, removed 86 packages, updated 67 packages, moved 1 package and audited 670 packages in 4.313s
found 3 vulnerabilities (1 low, 1 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
✔  17:27 ~/tslint [ update-nyc L | ✚ 1 ] $ git diff
diff --git a/package.json b/package.json
index 4202b145..5bf64351 100644
--- a/package.json
+++ b/package.json
@@ -65,7 +65,7 @@
-        "nyc": "^10.2.0",
+        "nyc": "^13.3.0",

Before:

=============================== Coverage summary ===============================
Statements   : 90.92% ( 9657/10621 )
Branches     : 87.23% ( 6017/6898 )
Functions    : 89.03% ( 1721/1933 )
Lines        : 90.4% ( 8748/9677 )
================================================================================

After:

=============================== Coverage summary ===============================
Statements   : 89.8% ( 8203/9135 )
Branches     : 86.61% ( 3576/4129 )
Functions    : 88.99% ( 1714/1926 )
Lines        : 89.15% ( 7239/8120 )
================================================================================

CHANGELOG.md entry:

[enhancement] Update nyc from v10.2.0 to v13.3.0

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, I didn't realize that our CI build here doesn't verify that the lockfile stays in sync with our declared dependencies. I'll merge this and fix that on master

@adidahiya adidahiya merged commit 73250af into palantir:master Apr 3, 2019
@bjornstar bjornstar deleted the update-nyc branch April 3, 2019 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants