Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix interface name rule #4626

Merged
merged 1 commit into from Apr 4, 2019
Merged

Fix interface name rule #4626

merged 1 commit into from Apr 4, 2019

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Apr 2, 2019

PR checklist

Overview of change:

I stoped to use isLowerCase or isUpperCase to use a real regex. These functions was buggy with numbers.

Is there anything you'd like reviewers to focus on?

I add a better support for prettier too.

CHANGELOG.md entry:

[bugfix] interface-name now correctly handle numeric characters

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine otherwise

tslint.json Outdated
"trailingComma": "all"
}
},
"prettier": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this part too

.prettierrc Outdated
@@ -0,0 +1,5 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert, don't make unrelated changes like this in PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in another PR

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. also please avoid force-pushing to PRs in the future. using regular commits helps me review incremental changes easier. we squash at the end of a PR.

@adidahiya adidahiya merged commit ab3c4d7 into palantir:master Apr 4, 2019
@VincentLanglet VincentLanglet mentioned this pull request Apr 11, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interface IX123abc throw an error
2 participants