This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Check for non-public modifiers in constructors (#4511) #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
suggested changes
Mar 31, 2019
There was a problem hiding this comment.
Logic LGTM, thanks for sending this @ericbf!
Just one slight improvement in the implementation details. We can apply the fix automatically if you don't see this soon, just figured you might want to get the satisfaction. 😄
This commit checks the modifiers of each constructor declaration. If it has any modifier that isn't `public`, then it's actually necessary and shouldn't be flagged by unnecessary-constructor rule.
|
Didn't know if GitHub would automatically identify the change as made 😆. Updated now. |
JoshuaKGoldberg
approved these changes
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit checks the modifiers of each constructor declaration. If it has any modifier that isn't
public, then it is actually necessary and shouldn't be flagged.PR checklist
Overview of change:
Iterate through the modifiers of each constructor declaration. If it has any modifiers that isn't
public, keep it.CHANGELOG.md entry:
[bugfix] unnecessary-constructor: don't flag constructors that are actually necessary