Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Added support for 'ignore-rest-args' option in 'no-any' rule #4581

Conversation

vmk1vmk
Copy link
Contributor

@vmk1vmk vmk1vmk commented Mar 17, 2019

PR checklist

Overview of change:

  • Added option ignore-rest-args to no-any lint rule.
  • Added tests to cover ignore-rest-args functionality.
  • Documented new rule by adding an option example and describing it's functionality.

CHANGELOG.md entry:

[new-rule-option] Added ignore-rest-args option to no-any

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @vmk1vmk! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@vmk1vmk vmk1vmk force-pushed the feature/issue-4437-no-any-rule-ignore-rest-args branch from 6529de4 to d91e52b Compare March 22, 2019 19:46
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to contributing @vmk1vmk! ✨

Sorry for the delay - this mostly looks good, just a couple of touchups.

src/rules/noAnyRule.ts Show resolved Hide resolved
src/rules/noAnyRule.ts Outdated Show resolved Hide resolved
@vmk1vmk vmk1vmk force-pushed the feature/issue-4437-no-any-rule-ignore-rest-args branch from 74c3ef3 to 88d5bfb Compare March 25, 2019 01:40
@JoshuaKGoldberg
Copy link
Contributor

👋 just a heads up @vmk1vmk, you don't need to force push. We squash commits on PRs anyway, and it's actually more useful to us as reviewers to see the commits as originally created.

@vmk1vmk
Copy link
Contributor Author

vmk1vmk commented Mar 25, 2019

@JoshuaKGoldberg Sorry I didn't know that, and thanks for putting the effort into the review.
I changed the code according to your changes so you can check if something is still missing.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks @vmk1vmk! 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants