[no-object-literal-type-assertion] New option: "allow-arguments"

[karol-majewski]

PR checklist

• Addresses an existing issue: no-object-literal-type-assertion rule in Reduce #4333
• Enhancement
  • Includes tests
• Documentation update

Overview of change:

This option allows using a type assertion when an object literal is used as an argument. A common use case is the second parameter for Array.prototype.reduce, where an empty object is often used as the initial value.

CHANGELOG.md entry:

[new-rule-option] no-object-literal-type-assertion rule accepts an option called allow-arguments. It allows using type assertions on object literals used inside call expressions.

[palantirtech]

Thanks for your interest in palantir/tslint, @karol-majewski! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[JoshuaKGoldberg]

Mostly looks good! Just a couple of touchups.

[JoshuaKGoldberg]

Awesome, thanks for this @karol-majewski! The implementation LGTM.

I'd like to get feedback from someone from @palantirtech on the design addition here, since it wasn't explicitly stated in the issue.

[luixo]

@adidahiya
Hey! I couldn't find any info about the review routine in palantir and I hope it's not a very rude question to ask, but is there any evaluated timing for the review? :)

[adidahiya]

lgtm otherwise

[adidahiya]

you don't need to wrap the object in an array, you can just bring the object out as the top level options value

[karol-majewski]

Done! Thank you.