Added no-tautology-expression rule #4470

noamyogev84 · 2019-01-19T12:50:14Z

PR checklist

Addresses an existing issue: Tautology Checker in Conditions #803
New feature
- Includes tests
Documentation update

Overview of change:

Add a basic rule that validates that two equal literals are not being compared.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[new-rule] no-tautology-expression

palantirtech · 2019-01-19T12:50:15Z

Thanks for your interest in palantir/tslint, @noamyogev84! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

src/rules/noTautologyExpressionRule.ts

noamyogev84 · 2019-01-19T16:34:36Z

Good to see you here @JoshuaKGoldberg . 😄
I'll continue to work on this.

noamyogev84 · 2019-01-19T21:11:33Z

@JoshuaKGoldberg,
I have these 2 errors when running yarn test:

1) Executable Files exits with code 0 if correct file is passed:
2) Executable Files exits with code 0 if several files passed without -f flag:
tried to follow 2 tests fail on just cloned repo #3443 with no success. Do you have any idea what's the problem?

JoshuaKGoldberg · 2019-01-19T21:56:51Z

☹ that's unfortunate @noamyogev84. For now, you can always delete those tests locally and/or only run yarn run test:rules, since your changes to add this rule don't affect those tests.

If that doesn't work for you, ping me on Gitter?

add unit tests

limit rule to validate only relational/logical expressions, add tests

noamyogev84 · 2019-01-29T19:43:50Z

Hi @JoshuaKGoldberg, sorry for the long wait. 🙏
Did some rework. Waiting for your review.

As you see, the error with yarn test i had locally, happens in the build server as well. 😢

noamyogev84 · 2019-02-09T12:55:02Z

H @JoshuaKGoldberg. Pinging you one more time... 🙏

JoshuaKGoldberg

Good progress! A few things to touch up.

src/rules/noTautologyExpressionRule.ts

test/rules/no-tautology-expression/test.ts.lint

src/rules/noTautologyExpressionRule.ts

JoshuaKGoldberg · 2019-02-09T15:38:20Z

Looking through the CircleCI failures, your rule has some kind of logic problem, because it's flagging acceptable binary expressions in TSLint's source as tautologies.

adidahiya · 2019-02-25T01:24:38Z

friendly ping @noamyogev84, do you expect to have time to return to this PR? thanks

noamyogev84 · 2019-03-01T09:13:56Z

Hi @adidahiya. I'll do some work, this weekend hopefully. 🕵️

…e_803

modified walk to cover additional cases add property access unit tests

noamyogev84 · 2019-03-01T21:24:57Z

Hi @JoshuaKGoldberg , @adidahiya .
added fixes and ready for you review. 🍻

JoshuaKGoldberg

Just the (late-breaking, sorry!) change for more primitive types! Otherwise this is looking great!

src/rules/noTautologyExpressionRule.ts

test/rules/no-tautology-expression/test.ts.lint

src/rules/noTautologyExpressionRule.ts

add unit tests

noamyogev84 · 2019-03-07T20:09:07Z

I think we're done 😃
@JoshuaKGoldberg

JoshuaKGoldberg · 2019-03-11T11:53:46Z

src/rules/noTautologyExpressionRule.ts

+                }
+            } else if (
+                (isBooleanLiteral(node.left) && isBooleanLiteral(node.right)) ||
+                (isNullLiteral(node.left) && isNullLiteral(node.right))


Continuing the previous conversation: this doesn't capture numeric literals or undefined.

numeric and string literals are covered earlier.
what about undefined? what do you mean by covering this ?

Oh, wow, I should review when fully awake. This looks great. I had forgotten undefined is an identifier.

JoshuaKGoldberg · 2019-03-11T19:22:14Z

src/rules/noTautologyExpressionRule.ts

+                }
+            } else if (
+                (isBooleanLiteral(node.left) && isBooleanLiteral(node.right)) ||
+                (isNullLiteral(node.left) && isNullLiteral(node.right))


Oh, wow, I should review when fully awake. This looks great. I had forgotten undefined is an identifier.

JoshuaKGoldberg · 2019-03-11T19:23:00Z

@noamyogev84 you've persisted superbly through multiple rounds of code review and slightly inaccurate questioning on my part. Thanks so much for the rule! This is going to be great for catching silly mistakes in user code.

noamyogev84 · 2019-03-12T08:15:24Z

@JoshuaKGoldberg it's my pleasure man! 🥃

noamyogev84 added 2 commits January 19, 2019 11:41

add new rule implementation

757d9e6

add some basic unit tests

2d13922

JoshuaKGoldberg changed the title ~~Issue 803~~ Added no-tautology-expressions rule Jan 19, 2019

JoshuaKGoldberg suggested changes Jan 19, 2019

View reviewed changes

src/rules/noTautologyExpressionRule.ts Outdated Show resolved Hide resolved

src/rules/noTautologyExpressionRule.ts Outdated Show resolved Hide resolved

src/rules/noTautologyExpressionRule.ts Show resolved Hide resolved

JoshuaKGoldberg added PR: waiting for reviewer PR: waiting for author labels Jan 19, 2019

fix some issues in rule

726a3d3

noamyogev84 added 3 commits January 25, 2019 09:07

add noTautologyExpressionRule,

f89be32

add unit tests

Merge remote-tracking branch 'upstream/master' into issue_803

64500ae

add examples to rule description,

f5c6eea

limit rule to validate only relational/logical expressions, add tests

JoshuaKGoldberg suggested changes Feb 9, 2019

View reviewed changes

JoshuaKGoldberg removed the PR: waiting for reviewer label Feb 9, 2019

noamyogev84 added 4 commits March 1, 2019 21:39

fix typo in isRelationalOrLogicalOperator

e948a3c

Merge branch 'master' of https://github.com/palantir/tslint into issu…

ced9d42

…e_803

modify isLiteral to use tsutils

211314e

modified walk to cover additional cases add property access unit tests

modify error message

6c39053

JoshuaKGoldberg suggested changes Mar 2, 2019

View reviewed changes

add checks for ts.NullLiteral, ts.BooleanLiteral

704df1c

add unit tests

JoshuaKGoldberg suggested changes Mar 11, 2019

View reviewed changes

JoshuaKGoldberg approved these changes Mar 11, 2019

View reviewed changes

JoshuaKGoldberg merged commit 55160ae into palantir:master Mar 11, 2019

adidahiya changed the title ~~Added no-tautology-expressions rule~~ Added no-tautology-expression rule Mar 12, 2019

adidahiya removed the PR: waiting for author label Mar 12, 2019

adidahiya mentioned this pull request Mar 13, 2019

Prepare release v5.14.0 #4576

Merged

JoshuaKGoldberg mentioned this pull request Mar 21, 2019

no-tautology-expression should check property access expressions #4593

Closed

snyk-bot mentioned this pull request Oct 11, 2019

[Snyk] Upgrade tslint from 5.11.0 to 5.20.0 Narshe1412/nuarca-sql#21

Merged

snyk-bot mentioned this pull request Oct 26, 2019

[Snyk] Upgrade tslint from 5.12.1 to 5.20.0 ajesse11x/caprover#5

Open

snyk-bot mentioned this pull request Nov 15, 2019

[Snyk] Upgrade tslint from 5.8.0 to 5.20.1 Matthelonianxl/cli-build-app#7

Open

snyk-bot mentioned this pull request Dec 15, 2019

[Snyk] Upgrade tslint from 5.11.0 to 5.20.1 dyna-dot/arxiv-bib-overlay#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added no-tautology-expression rule #4470

Added no-tautology-expression rule #4470

noamyogev84 commented Jan 19, 2019 •

edited by adidahiya

palantirtech commented Jan 19, 2019

noamyogev84 commented Jan 19, 2019

noamyogev84 commented Jan 19, 2019

JoshuaKGoldberg commented Jan 19, 2019

noamyogev84 commented Jan 29, 2019 •

edited

noamyogev84 commented Feb 9, 2019

JoshuaKGoldberg left a comment

JoshuaKGoldberg commented Feb 9, 2019

adidahiya commented Feb 25, 2019

noamyogev84 commented Mar 1, 2019 •

edited

noamyogev84 commented Mar 1, 2019

JoshuaKGoldberg left a comment

noamyogev84 commented Mar 7, 2019

JoshuaKGoldberg Mar 11, 2019

noamyogev84 Mar 11, 2019

JoshuaKGoldberg Mar 11, 2019

JoshuaKGoldberg Mar 11, 2019

JoshuaKGoldberg commented Mar 11, 2019 •

edited

noamyogev84 commented Mar 12, 2019

Added no-tautology-expression rule #4470

Added no-tautology-expression rule #4470

Conversation

noamyogev84 commented Jan 19, 2019 • edited by adidahiya

PR checklist

Overview of change:

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

palantirtech commented Jan 19, 2019

noamyogev84 commented Jan 19, 2019

noamyogev84 commented Jan 19, 2019

JoshuaKGoldberg commented Jan 19, 2019

noamyogev84 commented Jan 29, 2019 • edited

noamyogev84 commented Feb 9, 2019

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Feb 9, 2019

adidahiya commented Feb 25, 2019

noamyogev84 commented Mar 1, 2019 • edited

noamyogev84 commented Mar 1, 2019

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

noamyogev84 commented Mar 7, 2019

JoshuaKGoldberg Mar 11, 2019

Choose a reason for hiding this comment

noamyogev84 Mar 11, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 11, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 11, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg commented Mar 11, 2019 • edited

noamyogev84 commented Mar 12, 2019

noamyogev84 commented Jan 19, 2019 •

edited by adidahiya

noamyogev84 commented Jan 29, 2019 •

edited

noamyogev84 commented Mar 1, 2019 •

edited

JoshuaKGoldberg commented Mar 11, 2019 •

edited