You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Even with formatters-dir specified on the CLI, the built in formatters are used with preference to custom ones. This means plugins such as tslint-junit-formatter cannot be used.
Expected behavior
Customer formatter should be used even if it has the same name as a built in one, because the formatters-dir has been specified explicitly.
The text was updated successfully, but these errors were encountered:
In case someone says "who cares? there is already a built in junit formatter, why do you need another?" this module has a feature I need that the built in one doesn't (which I will also submit here as a feature request).
Seems reasonable, thanks for pointing this out @spikyjt! Although it's a breaking change, it's one users have to opt into and can easily remove, so it seems fine to accept PRs for now.
Customer formatter should be used even if it has the same name as a built in one, because the formatters-dir has been specified explicitly.
This formatters-dir is a place to look for additional formatters. If this change were made, I could argue that it is confusing for a developer to come across a project using a formatter called "junit" which is not the built-in one, when all other TS projects they have seen up to that point using the "junit" formatter utilized the built-in one.
Lastly, we should be consistent in how we make this change for custom rules & custom formatters. Currently, the documentation states:
Core rules cannot be overwritten with a custom implementation.
Leaving this issue open for discussion, we can reconsider if there's a lot of community interest in this change.
Bug Report
TypeScript code being linted
(N/A)
// code snippet
with
tslint.json
configuration:Actual behavior
Even with formatters-dir specified on the CLI, the built in formatters are used with preference to custom ones. This means plugins such as tslint-junit-formatter cannot be used.
Expected behavior
Customer formatter should be used even if it has the same name as a built in one, because the formatters-dir has been specified explicitly.
The text was updated successfully, but these errors were encountered: