Remove some difficult recommended rules #4312
Conversation
|
Thanks for your interest in palantir/tslint, @aghoneim92! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
There was a problem hiding this comment.
Thanks @aghoneim92!
This PR will have to wait until TSLint is ready to start merging in breaking changes ☹ but otherwise looks good.
|
|
|
#4871 is a superset of this. |
|
personally, I like |
In tslint version 6, several recommanded rules have been removed in the following PRs: palantir/tslint#4871 palantir/tslint#4312 With this change, we bring back these rules in the CLI.
In tslint version 6, several recommanded rules have been removed in the following PRs: palantir/tslint#4871 palantir/tslint#4312 With this migration we update the tslint depedency to 6+ and add back these rules in the user workspace `tslint.json` also we remove some deprecated rules. Until version 10, this is an opt-in migration and users will need to run this manually with the below command: ``` ng update @angular/cli --migrate-only tslint-version-6 ``` Closes: #17117 Reference: TOOL-1348
PR checklist
Overview of change:
Removed the following four rules from the recommended toolset:
Is there anything you'd like reviewers to focus on?
Should we remove even more rules? I personally don't like
member-orderingeither.CHANGELOG.md entry:
[enhancement] remove pedantic rules from the
recommendedconfig