This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
/
staticThisRule.ts
84 lines (71 loc) · 2.9 KB
/
staticThisRule.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
/**
* @license
* Copyright 2019 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import * as utils from "tsutils";
import * as ts from "typescript";
import * as Lint from "../index";
import { Replacement } from "../language/rule/rule";
import { codeExamples } from "./code-examples/staticThis.examples";
export class Rule extends Lint.Rules.AbstractRule {
/* tslint:disable:object-literal-sort-keys */
public static metadata: Lint.IRuleMetadata = {
ruleName: "static-this",
description: "Ban the use of `this` in static methods.",
hasFix: true,
options: null,
optionsDescription: "",
optionExamples: [true],
/* tslint:disable:max-line-length */
rationale: Lint.Utils.dedent`
Static \`this\` usage can be confusing for newcomers.
It can also become imprecise when used with extended classes when a static \`this\` of a parent class no longer specifically refers to the parent class.
`,
/* tslint:enable:max-line-length */
type: "functionality",
typescriptOnly: false,
codeExamples,
};
/* tslint:enable:object-literal-sort-keys */
public static FAILURE_STRING =
"Use the parent class name instead of `this` when in a `static` context.";
public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
return this.applyWithFunction(sourceFile, walk);
}
}
function walk(ctx: Lint.WalkContext<void>) {
let currentParentClass: ts.ClassLikeDeclaration | undefined;
const cb = (node: ts.Node): void => {
const originalParentClass = currentParentClass;
if (
utils.isClassLikeDeclaration(node.parent) &&
utils.hasModifier(node.modifiers, ts.SyntaxKind.StaticKeyword)
) {
currentParentClass = node.parent;
ts.forEachChild(node, cb);
currentParentClass = originalParentClass;
}
if (node.kind === ts.SyntaxKind.ThisKeyword && currentParentClass !== undefined) {
let fix: Replacement | undefined;
if (currentParentClass.name !== undefined) {
fix = Lint.Replacement.replaceNode(node, currentParentClass.name.text);
}
ctx.addFailureAtNode(node, Rule.FAILURE_STRING, fix);
return;
}
ts.forEachChild(node, cb);
};
ts.forEachChild(ctx.sourceFile, cb);
}