Add auto fixer for jsx-self-close-rule #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi again, just coming back for an update, is there anything missing in the PR ? |
adidahiya
suggested changes
Mar 12, 2019
|
|
||
|
|
||
|
|
||
| <h2 class="colouring" contents="B"/> |
There was a problem hiding this comment.
let's include a space right before the / here, to match what prettier would do with formatting
There was a problem hiding this comment.
Thanks for the review, I added the space for all the self-closing tags. Is it ok ?
QuentinBouygues
force-pushed
the
self-close-rule-fixer
branch
from
c524a59
to
b84602b
Compare
adidahiya
approved these changes
Mar 13, 2019
|
thanks @QuentinBouygues! in the future, please avoid force-pushing and use additional commits instead (we squash at the end of a PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds an auto fixer for the jsxSelfClose rule, along with a test and readme update.
As we throw an error when there are no node children, the fix just keeps the opening element and makes him self-closing
I'll keep an eye on the PR if changes are needed ! 馃槃