Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsx-key can't detect error in parenthesized expression #181

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Oct 5, 2018

Fix #187

The current implementation miss the case where an arrow function returns (); i.e.

[3, 4, 5].map(x => (<App />));
[3, 4, 5].map(x => (<App>app</App>));

It should be the following code instead.

[3, 4, 5].map(x => (<App key={x} />));
[3, 4, 5].map(x => (<App key={x}>app</App>));

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint-react, @lukyth! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@lukyth lukyth force-pushed the lukyth/jsx-key-parenthesized branch from d8205b3 to aeba27e Compare October 5, 2018 15:56
@jasongornall
Copy link

Could really use this!!

@lukyth
Copy link
Contributor Author

lukyth commented Dec 19, 2018

Anything I can do to get this merged?

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @lukyth!

@adidahiya adidahiya merged commit 1d689cb into palantir:master Mar 12, 2019
@lukyth lukyth deleted the lukyth/jsx-key-parenthesized branch March 13, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants