Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-theme] Regression in markdown rendering #3487

Closed
adidahiya opened this issue Apr 18, 2019 · 1 comment · Fixed by #3585
Closed

[docs-theme] Regression in markdown rendering #3487

adidahiya opened this issue Apr 18, 2019 · 1 comment · Fixed by #3585

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Apr 18, 2019

@blueprintjs/docs-theme 3.2.0

caused by #3482. Documentation markdown inside HTML tags is no longer being rendered correctly.

Actual behavior:

image
image

Expected behavior:

image
image

@adidahiya
Copy link
Contributor Author

adidahiya commented Jun 7, 2019

This seems to be a markedjs bug: markedjs/marked#985

We might switch to another markdown rendering library at some point, but for now I'm going to manually fix the "mixed" content using newlines between HTML tags and markdown to get the rendering back to what we expect.

VSCode's syntax highlighting for markdown suggests that this is a reasonable approach as well (I get the right highlighting for markdown inside HTML when I use newlines)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant