Fixes issues with incorrect indentation #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given a situation where bytes were written to the logger that do not end with a newline, then another set of bytes are written, the second set of bytes would be indented incorrectly. For example. First, write
some-data
, then writemore-data\nindent
. It should logsome-datamore-data\n indent
, but it actually writessome-data more-data\n indent
. There should not be an indent between the two writes because we only indent after a newline.Use Cases
This caused issues when indenting output from commands like
mvn
andcargo
.This PR resolves the issue and adds tests to confirm correct output.
Checklist