Allow disabling the BOM label #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently supporting the old-style BOM label and the new-style SBOM layer. By default, we output both. In some situations, if the BOM label grows large enough the resulting will not run on Kubernetes. It fails because the label is too large. You may now set the `BP_BOM_LABEL_DISABLED` env variable to `true` and on the next build, the BOM label will not be included with the image. The label is included by default, despite this known issue, to for backward compatibility. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are currently supporting the old-style BOM label and the new-style SBOM layer. By default, we output both.
In some situations, if the BOM label grows large enough the resulting will not run on Kubernetes. It fails because the label is too large. You may now set the
BP_BOM_LABEL_DISABLEDenv variable totrueand on the next build, the BOM label will not be included with the image.The label is included by default, despite this known issue, to for backward compatibility.
Checklist