Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Squeeze2 and transpose2 fuse using oneDNN #47712

Merged
merged 4 commits into from Nov 9, 2022
Merged

[cherry-pick] Squeeze2 and transpose2 fuse using oneDNN #47712

merged 4 commits into from Nov 9, 2022

Conversation

zh794390558
Copy link
Contributor

PR types

Performance optimization

PR changes

Others

Describe

ref #47592

@paddle-bot
Copy link

paddle-bot bot commented Nov 7, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zh794390558 zh794390558 changed the base branch from develop to release/2.4 November 7, 2022 05:57
@zh794390558 zh794390558 mentioned this pull request Nov 7, 2022
Open
@zh794390558 zh794390558 marked this pull request as draft November 7, 2022 11:54
@zh794390558 zh794390558 marked this pull request as ready for review November 7, 2022 11:54
yeliang2258
yeliang2258 previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@yeliang2258 yeliang2258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qili93
qili93 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for const_cast

chenwhql
chenwhql approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

ZeyuChen
ZeyuChen approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen changed the title [cherry-pick ]Squeeze2 transpose2 fuse onednn [cherry-pick] Squeeze2 and transpose2 fuse using oneDNN Nov 9, 2022
@ZeyuChen ZeyuChen merged commit ea5f44b into PaddlePaddle:release/2.4 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@qili93 qili93 qili93 approved these changes

@chenwhql chenwhql chenwhql approved these changes

@yeliang2258 yeliang2258 yeliang2258 left review comments

@jakpiase jakpiase Awaiting requested review from jakpiase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zh794390558 @ZeyuChen @qili93 @chenwhql @yeliang2258