Skip to content

Fix interaction response status type #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Fix interaction response status type #784

merged 1 commit into from
Dec 30, 2021

Conversation

beckerei
Copy link
Contributor

Currently, it is allowed to write

willRespondWith: {
  status: Matchers.like(200)
},

but the result will always be 500 as Matchers are not supported for the response status.

@TimothyJones
Copy link
Contributor

Great catch, thank you!

@TimothyJones
Copy link
Contributor

Is there a reason this is marked as a draft, other than you wanted us to look at it before merging?

@beckerei
Copy link
Contributor Author

Sorry, just out of habit. But I'm not sure why some builds fail 👀

@beckerei beckerei marked this pull request as ready for review December 30, 2021 09:00
@TimothyJones TimothyJones merged commit 97a0614 into pact-foundation:master Dec 30, 2021
@TimothyJones
Copy link
Contributor

The build failures are an unrelated issue that only happens on PRs for some reason. Something to do with the git config.

I’ve merged it and will release first thing tomorrow. Thanks for the PR!

@TimothyJones
Copy link
Contributor

Releasing 9.17.1 now with this fix. Thanks again, and happy new year!

@beckerei beckerei deleted the fix-response-option-type branch March 2, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants