Turn down the volume on tokio threads #699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to the unknown performance implications when it comes to crucible upstairs, this should not be merged until measurement can be performed on that front. |
hawkw
approved these changes
May 7, 2024
Rather than letting Tokio go wild with its default of spawning worker threads equal to the number of visible host CPUs, we constrain that number to the number of guest vCPUs (down to a minimum of 8). Fixes oxidecomputer#686
pfmooney
force-pushed
the
tone-down-threads
branch
from
5975d94
to
d5c4cfc
Compare
hawkw
approved these changes
May 8, 2024
mkeeter
reviewed
May 9, 2024
| @@ -42,6 +42,7 @@ use std::{ | |||
| time::Duration, | |||
| }; | |||
|
|
|||
| use anyhow::Context as AnyhowContext; | |||
There was a problem hiding this comment.
Hot tip: if you need trait methods to be in-scope but the name is colliding, you can do
Suggested change
| use anyhow::Context as AnyhowContext; | |
| use anyhow::Context as _; |
pfmooney
pushed a commit
to pfmooney/propolis
that referenced
this pull request
May 16, 2024
Picks up:
* 9f69dea - Actually provision read-only downstairs! (#728)
* 92ae012 - crutest use SIGUSR1 to stop tests (oxidecomputer#699)
* 47f3569 - Add build info and version commands (oxidecomputer#709)
* 07f0a9e - Give up on a downstairs (#725)
* 9985a4c - Slightly better versioning between upstairs and downstairs (oxidecomputer#705)
* 0b34a53 - Fix paths in method scripts (oxidecomputer#703)
* 12b65eb - [smf] Allow Crucible Zones to be self-assembling (oxidecomputer#498)
Also updates uuid dep to 1.3.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than letting Tokio go wild with its default of spawning worker threads equal to the number of visible host CPUs, we constrain that number to the number of guest vCPUs (down to a minimum of 8).
Fixes #686