Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiate devices from migration payload #668

Open
pfmooney opened this issue Mar 20, 2024 · 1 comment
Open

instantiate devices from migration payload #668

pfmooney opened this issue Mar 20, 2024 · 1 comment

Comments

@pfmooney
Copy link
Collaborator

During a migration, the current logic requires the target instance to be initialized with devices exactly matching the source. Those devices are then "rehydrated" with the migration payloads exported from the source, when that phase of the migration occurs. After discussions with @gjcolombo and others, one recurring conclusion was that it'd be nice if we could instantiate the devices directly from the migration payload.

Doing so would require some restructuring, particularly around what resources are required by each respective device when it is created. Viona, for example, requires the underlying vnic resource for initialization today. Moving it to a model similar to block devices, where it is attached to a "backend" resource prior to being pressed into service, might make sense.

An initialization pattern like this may help free us from demanding that the source and target VM instances adhere to similar internal structures when it comes to device naming, etc.

@hawkw
Copy link
Member

hawkw commented Mar 20, 2024

This would make some of the work I started a bit ago on IRQ pins a lot nicer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants