Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propolis should limit tokio workers #666

Open
pfmooney opened this issue Mar 18, 2024 · 1 comment
Open

propolis should limit tokio workers #666

pfmooney opened this issue Mar 18, 2024 · 1 comment

Comments

@pfmooney
Copy link
Collaborator

By default, the tokio runtime will spawn a number of worker threads equal to the number of visible logical CPUs it finds on the system. No instance should ever be able to make use of all that CPU (especially since it has its own separate threads for driving the guest vCPUs), so it would make sense to limit the number of threads created by the tokio runtime.

@pfmooney
Copy link
Collaborator Author

Related to this, Crucible's use of the rayon crate means it too is creating a bunch of worker threads. If propolis is making thread scaling decisions, it should probably help Crucible with the task too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant