Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

want migration status endpoints to report source and target migration IDs separately #508

Open
gjcolombo opened this issue Aug 25, 2023 · 0 comments · May be fixed by #661
Open

want migration status endpoints to report source and target migration IDs separately #508

gjcolombo opened this issue Aug 25, 2023 · 0 comments · May be fixed by #661
Labels
enhancement New feature or request. migration Issues related to live migration.
Milestone

Comments

@gjcolombo
Copy link
Contributor

Propolis's instance status endpoint only reports the ID of the most recent migration that it participated in, irrespective of whether this was a migration in or a migration out. This causes sled agent to have to assume that when Propolis reports a migration ID that sled agent and Nexus don't know about, it's because the Propolis was previously initialized via migration in.

If instead Propolis separately reported incoming and outgoing migration IDs, sled agent could raise warnings of a misbehaving Propolis if it ever saw one report an in-progress migration out whose ID wasn't known to sled agent. Such cases are bugs because Nexus and the sled agents involved in a migration are supposed to agree on the new migration's ID before ever communicating it to a Propolis.

This is a nice-to-have to simplify some sled agent logic. It's not a showstopper for control plane-directed live migration.

@gjcolombo gjcolombo added enhancement New feature or request. migration Issues related to live migration. labels Aug 25, 2023
@gjcolombo gjcolombo added this to the Unscheduled milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. migration Issues related to live migration.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant