Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic count metrics could possibly be combined for easier analysis #660

Open
bnaecker opened this issue Mar 9, 2024 · 0 comments
Open

Comments

@bnaecker
Copy link
Contributor

bnaecker commented Mar 9, 2024

Propolis maintains two metrics counting panics in the guest, and distinguishes between guest- and host-handled panics as different timeseries. Here:

struct PvPanicGuestHandled {

and here:

struct PvPanicHostHandled {

We may want to collapse these into one timeseries counting total panics, with a field to indicate who handled it (guest or host). But it's not clear from the PVPANIC documentation whether these two are mutually exclusive. If not, two timeseries would be needed. But if so, we may want to collapse them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant