Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move type definitions out of propolis-client #554

Open
pfmooney opened this issue Oct 19, 2023 · 0 comments
Open

Move type definitions out of propolis-client #554

pfmooney opened this issue Oct 19, 2023 · 0 comments

Comments

@pfmooney
Copy link
Collaborator

There are several swaths of types, relating to instance specs and the serial console, defined in the propolis-client lib today. Some of those are then re-exported in that same library from the code generated by progrenitor, based of the openapi json defined by propolis-server. While the handmade client code in propolis-client served a purpose early-on, as the progenitor-based bits were still being hammered out, we should clean that up so that its little more than the progenitor definition, plus whatever small helpers we deem necessary.

Types exposed by the openapi-visible portion of propolis-server should go in some sort of crate or module, used only by propolis-server (and perhaps the mock-server), rather than living in propolis-client. This will cut down on the dependencies required by propolis-client consumers as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant