Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependencies] Consider switching from ipnetwork to ipnet for IP network management #877

Open
smklein opened this issue Apr 5, 2022 · 3 comments
Labels
cleanup Code cleanliness

Comments

@smklein
Copy link
Collaborator

smklein commented Apr 5, 2022

ipnetwork - currently used in omicron - and ipnet (not used yet) serve very similar purposes: they both track network addresses, ranges, and subnets.

Background

Progress

Doing so would let us move to a crate with slightly better subnet-management functionality, and a better cadence of support.

@smklein
Copy link
Collaborator Author

smklein commented May 4, 2022

Adding ipnet support to diesel has been proposed with diesel-rs/diesel#3164 , and implemented with diesel-rs/diesel#3165

@ahl
Copy link
Contributor

ahl commented Jun 30, 2022

Maybe relevant: achanda/ipnetwork#157

@bnaecker
Copy link
Collaborator

bnaecker commented Jul 22, 2022

Also: diesel-rs/diesel#3244

It seems that this now means we can just use ipnet and its types directly, both in the external API and the database representation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanliness
Projects
None yet
Development

No branches or pull requests

3 participants