Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support naming Tokio tasks #853

Open
adamchalmers opened this issue Dec 18, 2023 · 0 comments
Open

Support naming Tokio tasks #853

adamchalmers opened this issue Dec 18, 2023 · 0 comments

Comments

@adamchalmers
Copy link
Contributor

adamchalmers commented Dec 18, 2023

Tokio has a task::Builder interface which lets you give tasks names. It's useful for identifying tasks in the Tokio console.

This API is only available on "tokio_unstable" Rust flag, and tokio crate feature tracing. So Dropshot would need to check for the "tokio_unstable" in RUSTFLAGS and conditionally enable the tracing tokio feature.

This builder API is open to change (obviously, given the "tokio_unstable" name). So maybe y'all aren't open to supporting this feature right now. But it would be a nice feature for people using tokio console.

Engineers at KittyCAD are open to doing the implementation of this, but just opening this issue to discuss if y'all are open to the idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant