Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that max request body size is enforced for chunked encoding #545

Open
mx-shift opened this issue Jan 6, 2023 · 1 comment
Open

Comments

@mx-shift
Copy link

mx-shift commented Jan 6, 2023

HTTP does not specify a limit on request body size but allows implementations to enforce one to allow bounding of resource usage. When chunked encoding is used, the request body length is not known upfront and is only known incrementally as each chunk is received. Dropshot has a config option to set a maximum request body size but no test to verify that that limit is enforced when chunked encoding is used and a steady stream of chunks, each individually smaller than the limit, are received.

@sunshowers
Copy link
Contributor

This might interact with #542 -- I believe the way it's done today and in #542 makes it so that we check the actual request length rather than just relying on what the header says.

Still most likely need a test for this though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants