-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processed MessageCard message has no topic, preventing image cards from linking to Friends. #1684
Comments
Is this on HTTP or MQTT? |
Sorry, should have clarified: HTTP I've been testing the PR "status command", and noticed the logs show that the topic is blank for MessageCmd as well. For example, this is what is showing:
It seems the incoming topic isn't being mapped to those. |
Ok, I see the issue. The override for HTTP is structured to only check the location message: In 2.4, the trackerID was a field in the message base. |
I created a PR to add "tid" to the MessageCard. That would restore the behavior 2.4.x had. The current architecture is keying off getContactId() which requires a topic to link the two. The online booklet should be updated to indicate the necessary "tid" field. |
So this is a little more complex than just adding the Obviously on HTTP, there's no built-in concept of a "message topic", so we use a separate JSON field called How are you generating card messages to send to the app? Can you see if they've got a |
In order to get cards to work on 2.4.12, I had added a Right now there is no |
I ran some additional tests, and without |
I can confirm cards were not supposed to work in the iOS app in HTTP mode. Using a The apps are not designed for HTTP... |
Since it does currently work on the published iOS and Android versions on HTTP, is there any reason it cannot be documented that it does and add back the changes to Android? Seems odd to restrict HTTP functionality that is working based on the premise the original architecture was designed with only MQTT in mind. |
Thoughts on this one? Is there a better way that you'd prefer this gets implemented (that also works with the iOS)? |
Testing from the current tip of master (and from 2.5.0 Beta-1), the message cards fail to link to the Friends. Digging into the logs/flow, the logs, when this function is called for
MessageCard
,message.topic
is null. If I hard code a topic that matches the one displayed from aMessageLocation
message, then the code functions as expected.Not sure where to dig further to see what was missed.
The text was updated successfully, but these errors were encountered: